Re: [PATCH v2] PCI: mediatek-gen3: Fix translation window

From: AngeloGioacchino Del Regno
Date: Mon Oct 23 2023 - 08:32:28 EST


Il 23/10/23 10:14, Jianjun Wang ha scritto:
The size of translation table should be a power of 2, using fls()
cannot get the proper value when the size is not a power of 2. For
example, fls(0x3e00000) - 1 = 25, hence the PCIe translation window
size will be set to 0x2000000 instead of the expected size 0x3e00000.

Fix translation window by splitting the MMIO space to multiple tables if
its size is not a power of 2.

Fixes: d3bf75b579b9 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192")
Signed-off-by: Jianjun Wang <jianjun.wang@xxxxxxxxxxxx>


Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>