Re: [PATCH v1 0/5] soc/arm64: qcom: add initial version of memory dump

[Zhenhua Huang]

On 2023/10/23 17:25, Krzysztof Kozlowski wrote:
> On 23/10/2023 11:20, Zhenhua Huang wrote:
> > Qualcomm memory dump driver is to cooperate with firmware, providing the
> > hints(id and size) of storing useful debugging information into pre-allocated
> > memory. Firmware then does the real data capture. The debugging information
> > includes cache contents, internal memory, registers.
> >
> > The driver dynamically reserves memory and provides the hints(dump id and size)
> > following specified protocols with firmware. After crash and warm reboot,
> > firmware scans these information and stores contents into reserved memory
> > accordingly. Firmware then enters into full dump mode which dumps whole DDR
> > to host through USB.
>
> How does it relate to minidump?

Minidump is used for dumping *software* related data/information. While 
the memory dump is used to communicate with firmware to dump *hardware* 
related information.

> > User then get full dump using PCAT and can parse out these informations.
> >
> > Dump id and size are provided by bootconfig. The expected format of a
> > bootconfig file is as follows:-
> > memory_dump_config {
> > 	<node name> {
> > 		id = <id of HW component>
> > 		size = <dump size of HW component>
> > 	}
> > }
> >
> > for example:
> > memory_dump_config {
> >          c0_context_dump {
> > 		id = 0
> > 		size = 0x800
> >          }
> > }
> >
> > Test based on 6.6-rc1.
>
> I don't think so (or you miss yamllint).
>
> $ git checkout v6.6-rc1
> $ b4 am...
> $ dt_binding_chec

Apologize for this. I actually run it but seems some mistakes here, will 
be more careful next time.

> qcom,mem-dump.yaml:5:10: [error] string value is redundantly quoted with
> any quotes (quoted-strings)
>
>
> Best regards,
> Krzysztof

Thanks,
Zhenhua