Re: [RESEND PATCH v7 2/5] leds: sun50i-a100: New driver for the A100 LED controller

[Lee Jones]

> Hi Samuel,
> 
> there are two more things to change, which came up recently. See below.
> 
> Regards,
> André
> 
> Am Samstag, dem 31.12.2022 um 17:55 -0600 schrieb Samuel Holland:
> > Some Allwinner sunxi SoCs, starting with the A100, contain an LED
> > controller designed to drive RGB LED pixels. Add a driver for it
> > using
> > the multicolor LED framework, and with LEDs defined in the device
> > tree.
> > 
> > Acked-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
> > Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx>
> > ---
> > [...]
> > diff --git a/drivers/leds/leds-sun50i-a100.c b/drivers/leds/leds-
> > sun50i-a100.c

[...]

> > +struct sun50i_a100_ledc {
> > +	struct device *dev;
> > +	void __iomem *base;
> > +	struct clk *bus_clk;
> > +	struct clk *mod_clk;
> > +	struct reset_control *reset;
> > +
> > +	u32 *buffer;
> > +	struct dma_chan *dma_chan;
> > +	dma_addr_t dma_handle;
> > +	int pio_length;
> > +	int pio_offset;
> > +
> > +	spinlock_t lock;
> > +	int next_length;
> > +	bool xfer_active;
> > +
> > +	u32 format;
> > +	struct sun50i_a100_ledc_timing timing;
> > +
> > +	int num_leds;
> > +	struct sun50i_a100_ledc_led leds[];
> 
> Annotate struct with  __counted_by(num_leds).

André, please remember to snip your replies.

-- 
Lee Jones [李琼斯]