Re: [PATCH] wifi: iwlwifi: Add check for kmemdup

From: Johannes Berg
Date: Mon Oct 23 2023 - 05:10:22 EST


On Mon, 2023-10-23 at 12:08 +0300, Kalle Valo wrote:
> Chen Ni <nichen@xxxxxxxxxxx> writes:
>
> > Since the kmemdup may return NULL pointer,
> > it should be better to add check for the return value
> > in order to avoid NULL pointer dereference.
> >
> > Fixes: 5e31b3df86ec ("wifi: iwlwifi: dbg: print pc register data once
> > fw dump occurred")
>
> The fixes tag should be in one line.
>

It's also irrelevant because (a) the fix is incorrect, and (b) we
already have a (correct) fix :)

johannes