Re: [PATCH 10/11] ARM: dts: qcom: Update devicetree for QCOM ADC bindings path change

From: Krzysztof Kozlowski
Date: Mon Oct 23 2023 - 02:38:13 EST


On 23/10/2023 08:18, Jishnu Prakash wrote:
> Hi Krzysztof,
>
> On 7/9/2023 10:56 PM, Krzysztof Kozlowski wrote:
>> On 08/07/2023 09:28, Jishnu Prakash wrote:
>>> Update ADC dt-bindings file paths in QCOM devicetree files to
>>> match the dt-bindings change moving the files from 'iio' to
>>> 'iio/adc' folder.
>>>
>>> Signed-off-by: Jishnu Prakash <quic_jprakash@xxxxxxxxxxx>
>>> ---
>> Your order of patches is incorrect. DTS cannot be before bindings,
>> because this indicates you broke ABI. Please keep entire patchset
>> bisectable and split DTS to separate patchset (linking the driver and
>> bindings).
>>
>> Best regards,
>> Krzysztof
>
> OK....so you mean I can move the dtbinding files and update
> documentation and driver files for this, all in one patch and then make

No

> a second patch for updating devicetree files for the file paths?

No. And this proves the patchset is broken.


Best regards,
Krzysztof