Re: [PATCH 04/11] iio: adc: Update bindings to remove support for ADC7 name used on QCOM PMICs

From: Krzysztof Kozlowski
Date: Mon Oct 23 2023 - 02:33:41 EST


On 23/10/2023 08:11, Jishnu Prakash wrote:
> Hi Krzysztof,
>
> On 7/9/2023 10:49 PM, Krzysztof Kozlowski wrote:
>> On 08/07/2023 09:28, Jishnu Prakash wrote:
>>> Now that usage of "ADC7" name has been replaced with usage of "ADC5
>>> Gen2" name everywhere, remove all support for "ADC7" name.
>> Why?
>
> The idea is to replace usage of the name "ADC7" with "ADC5 Gen2"
> everywhere possible, to match our internal convention and align better

That's not a valid reason to touch bindings. Compatible is just some
unique name, so there is nothing bad in existing name.

> with the "ADC5 Gen3" support I'm adding in this patch series - is it
> better if I just update documentation and dtbindings directly in one
> patch for ADC5 Gen2 and update devicetree in one patch after that for
> the corresponding macro changes?

Don't touch the compatible.

Best regards,
Krzysztof