Re: [PATCH RFC v2 0/8] blk-mq: improve tag fair sharing

From: Ming Lei
Date: Mon Oct 23 2023 - 00:39:21 EST


Hello Yu Kuai,

On Sat, Oct 21, 2023 at 11:47:58PM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@xxxxxxxxxx>
>
> Current implementation:
> - a counter active_queues record how many queue/hctx is sharing tags,
> and it's updated while issue new IO, and cleared in
> blk_mq_timeout_work().
> - if active_queues is more than 1, then tags is fair shared to each
> node;

Can you explain a bit what the problem is in current tag sharing?
And what is your basic approach for this problem?

Just mentioning the implementation is not too helpful for initial
review, cause the problem and approach(correctness) need to be
understood first.

Thanks,
Ming