Re: [PATCH] staging: greybus: Alignment should match open parenthesis

From: Greg Kroah-Hartman
Date: Sat Oct 21 2023 - 05:48:43 EST


On Thu, Oct 19, 2023 at 02:39:49PM -0700, Nandha Kumar Singaram wrote:
> Adhere to linux coding style. Reported by checkpatch.pl:
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@xxxxxxxxx>
> ---
> drivers/staging/greybus/camera.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
> index cdbb42cd413b..405c8e78aa72 100644
> --- a/drivers/staging/greybus/camera.c
> +++ b/drivers/staging/greybus/camera.c
> @@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection,
> }
>
> static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
> - struct gb_camera_configure_streams_response *resp)
> + struct gb_camera_configure_streams_response *resp)
> {
> unsigned int max_pkt_size = 0;
> unsigned int i;
> @@ -267,8 +267,7 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
> * Validate the stream configuration response verifying padding is correctly
> * set and the returned number of streams is supported
> */
> -static const int gb_camera_configure_streams_validate_response(
> - struct gb_camera *gcam,
> +static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,

Why change this line?

It's fine, but then:

> struct gb_camera_configure_streams_response *resp,
> unsigned int nstreams)

These lines are not fixed up?

thanks,

greg k-h