Re: [PATCH] cdrom: Missing a blank line after declarations

From: Phillip Potter
Date: Fri Oct 20 2023 - 15:01:59 EST


On Mon, Oct 16, 2023 at 09:33:44PM +0100, Phillip Potter wrote:
>
> Hi Edson,
>
> Thanks for the patch, looks good to me, will send on for inclusion. That
> said, I will also tweak the title/commit description to a more imperative
> style, given that this description itself currently triggers
> checkpatch.pl due to line length.
>
> Reviewed-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>
>
> Regards,
> Phil

Hi Edson,

After conversing with the Block maintainer (Jens Axboe) it has been
decided that this will not infact be merged, as all it does is introduce
newlines and patches of this type generally just cause problem for
auto-application of patches to stable kernel branches. Thank you anyway
though, and by all means feel free to send other CD-ROM patches my way
in future.

Regards,
Phil