Re: [PATCH] selftests/clone3: Skip new time namespace test when unsupported

From: Mark Brown
Date: Fri Oct 20 2023 - 07:46:49 EST


On Thu, Oct 19, 2023 at 04:35:38PM -0700, Andrew Morton wrote:
> On Fri, 20 Oct 2023 00:08:12 +0100 Mark Brown <broonie@xxxxxxxxxx> wrote:

> > Use a filter function to skip the time namespace test on systems with
> > !CONFIG_TIME_NS. This reworks a fix originally done by Tiezhu Yang prior
> > to the refactoring in 34dce23f7e40 ("selftests/clone3: Report descriptive
> > test names"). The changelog from their fix explains the issue very clearly:

> I was about to send Tiezhu Yang's fix to Linus. I'll rebase mm-hotfixes-stable
> to drop that patch, so you own it now!

> Please note that your version lacks an explicit cc:stable, but I suppose the
> stablebots will scoop it up anyway.

I think I was expecting Tiezhu's version to still get sent and then the
two versions to get merged - the refactoring that caused the conflict is
very clearly not stable material.

> > Original-fix-from: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>

> "Original-fix-from" isn't a thing. In fact it seems to be the first
> time this has been used. Grepping for "Original-.*:" shows
> all sorts of innovations, including "Based-on-the-original-screenplay-by:".

> I guess Documentation/process/submitting-patches.rst and checkpatch
> lost this fight a long time ago.

Well, they've always been documenting existing practice.

Attachment: signature.asc
Description: PGP signature