Re: [PATCH v2] stop_machine: Avoid potential non-atomic read of multi_stop_data::state

From: Peter Zijlstra
Date: Fri Oct 20 2023 - 06:48:38 EST


On Fri, Oct 20, 2023 at 11:23:37AM +0100, Mark Rutland wrote:

> > And replace smp_wmb()+WRITE_ONCE() with smp_store_release().
>
> This is also fine, but feels like a logically separate change.

Agreed, and please take this opportunity to write a comment with the
barrier.