Re: [PATCH] b43legacy: Removed unneeded variable in debugfs

From: Michael Büsch
Date: Fri Oct 20 2023 - 05:36:24 EST


On Fri, 20 Oct 2023 14:57:35 +0530
Bragatheswaran Manickavel <bragathemanick0908@xxxxxxxxx> wrote:

> Removed unneeded variable. Issue identified using Coccinelle semantic.
> No functional impact

This patch is completely wrong. It would not even compile.
Please compile your patches before submitting them!

And it is the second time we see this nonsense.
The code is correct as-is. There is no unused variable.

NACK.

--
Michael Büsch
https://bues.ch/

Attachment: pgpq7UpWdbjH0.pgp
Description: OpenPGP digital signature