Re: [PATCH] clk: mediatek: mt8186: Change I2C 4/5/6 ap clocks parent to infra

[AngeloGioacchino Del Regno]

Il 20/10/23 07:06, Chen-Yu Tsai ha scritto:
> On Thu, Oct 19, 2023 at 8:49 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@xxxxxxxxxxxxx> wrote:
> > Fix the parenting of clocks imp_iic_wrap_ap_clock_i2c{4-6}, as those
> > are effectively parented to infra_ao_i2c{4-6} and not to the I2C_AP.
> > This permits the correct (and full) enablement and disablement of the
> > I2C4, I2C5 and I2C6 bus clocks, satisfying the whole clock tree of
> > those.
> >
> > As an example, when requesting to enable imp_iic_wrap_ap_clock_i2c4:
> >
> > Before: infra_ao_i2c_ap -> imp_iic_wrap_ap_clock_i2c4
> > After:  infra_ao_i2c_ap -> infra_ao_i2c4 -> imp_iic_wrap_ap_clock_i2c4
> >
> > Fixes: 66cd0b4b0ce5 ("clk: mediatek: Add MT8186 imp i2c wrapper clock support")
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
>
> I'm curious about what led to discovering this error?

I had lockups during boot when probing I2C, so some research led me to
discover that the clock tree wasn't fully satisfied... :-)

Cheers,
Angelo

> ChenYu
>
> > ---
> >   drivers/clk/mediatek/clk-mt8186-imp_iic_wrap.c | 6 +++---
> >   drivers/clk/mediatek/clk-mt8186-infra_ao.c     | 6 +++---
> >   2 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/clk/mediatek/clk-mt8186-imp_iic_wrap.c b/drivers/clk/mediatek/clk-mt8186-imp_iic_wrap.c
> > index 640ccb553274..871b8ff4c287 100644
> > --- a/drivers/clk/mediatek/clk-mt8186-imp_iic_wrap.c
> > +++ b/drivers/clk/mediatek/clk-mt8186-imp_iic_wrap.c
> > @@ -29,11 +29,11 @@ static const struct mtk_gate imp_iic_wrap_clks[] = {
> >          GATE_IMP_IIC_WRAP(CLK_IMP_IIC_WRAP_AP_CLOCK_I2C3,
> >                  "imp_iic_wrap_ap_clock_i2c3", "infra_ao_i2c_ap", 3),
> >          GATE_IMP_IIC_WRAP(CLK_IMP_IIC_WRAP_AP_CLOCK_I2C4,
> > -               "imp_iic_wrap_ap_clock_i2c4", "infra_ao_i2c_ap", 4),
> > +               "imp_iic_wrap_ap_clock_i2c4", "infra_ao_i2c4", 4),
> >          GATE_IMP_IIC_WRAP(CLK_IMP_IIC_WRAP_AP_CLOCK_I2C5,
> > -               "imp_iic_wrap_ap_clock_i2c5", "infra_ao_i2c_ap", 5),
> > +               "imp_iic_wrap_ap_clock_i2c5", "infra_ao_i2c5", 5),
> >          GATE_IMP_IIC_WRAP(CLK_IMP_IIC_WRAP_AP_CLOCK_I2C6,
> > -               "imp_iic_wrap_ap_clock_i2c6", "infra_ao_i2c_ap", 6),
> > +               "imp_iic_wrap_ap_clock_i2c6", "infra_ao_i2c6", 6),
> >          GATE_IMP_IIC_WRAP(CLK_IMP_IIC_WRAP_AP_CLOCK_I2C7,
> >                  "imp_iic_wrap_ap_clock_i2c7", "infra_ao_i2c_ap", 7),
> >          GATE_IMP_IIC_WRAP(CLK_IMP_IIC_WRAP_AP_CLOCK_I2C8,
> > diff --git a/drivers/clk/mediatek/clk-mt8186-infra_ao.c b/drivers/clk/mediatek/clk-mt8186-infra_ao.c
> > index 837304cd0ed7..c490f1a310f8 100644
> > --- a/drivers/clk/mediatek/clk-mt8186-infra_ao.c
> > +++ b/drivers/clk/mediatek/clk-mt8186-infra_ao.c
> > @@ -132,7 +132,7 @@ static const struct mtk_gate infra_ao_clks[] = {
> >          GATE_INFRA_AO2(CLK_INFRA_AO_AUDIO_26M_BCLK, "infra_ao_audio26m", "clk26m", 4),
> >          GATE_INFRA_AO2(CLK_INFRA_AO_SSUSB_TOP_P1_HCLK, "infra_ao_ssusb_p1_hclk", "top_axi", 5),
> >          GATE_INFRA_AO2(CLK_INFRA_AO_SPI1, "infra_ao_spi1", "top_spi", 6),
> > -       GATE_INFRA_AO2(CLK_INFRA_AO_I2C4, "infra_ao_i2c4", "top_i2c", 7),
> > +       GATE_INFRA_AO2(CLK_INFRA_AO_I2C4, "infra_ao_i2c4", "infra_ao_i2c_ap", 7),
> >          GATE_INFRA_AO2(CLK_INFRA_AO_MODEM_TEMP_SHARE, "infra_ao_mdtemp", "clk26m", 8),
> >          GATE_INFRA_AO2(CLK_INFRA_AO_SPI2, "infra_ao_spi2", "top_spi", 9),
> >          GATE_INFRA_AO2(CLK_INFRA_AO_SPI3, "infra_ao_spi3", "top_spi", 10),
> > @@ -145,7 +145,7 @@ static const struct mtk_gate infra_ao_clks[] = {
> >          GATE_INFRA_AO2_FLAGS(CLK_INFRA_AO_SSPM, "infra_ao_sspm", "top_sspm", 15, CLK_IS_CRITICAL),
> >          GATE_INFRA_AO2(CLK_INFRA_AO_SSUSB_TOP_P1_SYS,
> >                         "infra_ao_ssusb_p1_sys", "top_ssusb_1p", 16),
> > -       GATE_INFRA_AO2(CLK_INFRA_AO_I2C5, "infra_ao_i2c5", "top_i2c", 18),
> > +       GATE_INFRA_AO2(CLK_INFRA_AO_I2C5, "infra_ao_i2c5", "infra_ao_i2c_ap", 18),
> >          GATE_INFRA_AO2(CLK_INFRA_AO_I2C5_ARBITER, "infra_ao_i2c5a", "top_i2c", 19),
> >          GATE_INFRA_AO2(CLK_INFRA_AO_I2C5_IMM, "infra_ao_i2c5_imm", "top_i2c", 20),
> >          GATE_INFRA_AO2(CLK_INFRA_AO_I2C1_ARBITER, "infra_ao_i2c1a", "top_i2c", 21),
> > @@ -167,7 +167,7 @@ static const struct mtk_gate infra_ao_clks[] = {
> >                               CLK_IS_CRITICAL),
> >          GATE_INFRA_AO3_FLAGS(CLK_INFRA_AO_SSPM_32K_SELF, "infra_ao_sspm_32k", "clk32k", 4,
> >                               CLK_IS_CRITICAL),
> > -       GATE_INFRA_AO3(CLK_INFRA_AO_I2C6, "infra_ao_i2c6", "top_i2c", 6),
> > +       GATE_INFRA_AO3(CLK_INFRA_AO_I2C6, "infra_ao_i2c6", "infra_ao_i2c_ap", 6),
> >          GATE_INFRA_AO3(CLK_INFRA_AO_AP_MSDC0, "infra_ao_ap_msdc0", "top_axi", 7),
> >          GATE_INFRA_AO3(CLK_INFRA_AO_MD_MSDC0, "infra_ao_md_msdc0", "top_axi", 8),
> >          GATE_INFRA_AO3(CLK_INFRA_AO_MSDC0_SRC, "infra_ao_msdc0_clk", "top_msdc50_0", 9),
> > --
> > 2.42.0