Re: [PATCH v2 2/2] staging: vme_user: Use __func__ instead of function name

[Soumya Negi]

On Thu, Oct 19, 2023 at 05:41:12PM +0200, Andi Shyti wrote:
> Hi Soumya,
> 
> On Thu, Oct 19, 2023 at 12:20:10AM -0700, Soumya Negi wrote:
> > Replace function names in message strings with __func__ to fix
> > all checkpatch warnings like:
> > 
> >     WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get',
> >              this function's name, in a string
> > 
> > Signed-off-by: Soumya Negi <soumya.negi97@xxxxxxxxx>
> 
> you forgot my ack here:
> 
> Acked-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> 
> 
> Andi

Sorry I forgot the tag Andi. I'll add the tags in v3(Greg has suggested
more changes). There will be some new patches, so I'll leave the tags out in 
those as you may want to review them first.

Regards,
Soumya
> 
> > ---
> > Changes in v2:
> > * None
> > 
> >  drivers/staging/vme_user/vme.c | 14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
> > index 640b2dda3ac6..e533cce8e54e 100644
> > --- a/drivers/staging/vme_user/vme.c
> > +++ b/drivers/staging/vme_user/vme.c
> > @@ -424,7 +424,7 @@ int vme_slave_get(struct vme_resource *resource, int *enabled,
> >  	image = list_entry(resource->entry, struct vme_slave_resource, list);
> >  
> >  	if (!bridge->slave_get) {
> > -		dev_err(bridge->parent, "vme_slave_get not supported\n");
> > +		dev_err(bridge->parent, "%s not supported\n", __func__);
> >  		return -EINVAL;
> >  	}
> >  
> > @@ -576,7 +576,7 @@ int vme_master_set(struct vme_resource *resource, int enabled,
> >  	image = list_entry(resource->entry, struct vme_master_resource, list);
> >  
> >  	if (!bridge->master_set) {
> > -		dev_warn(bridge->parent, "vme_master_set not supported\n");
> > +		dev_warn(bridge->parent, "%s not supported\n", __func__);
> >  		return -EINVAL;
> >  	}
> >  
> > @@ -1576,7 +1576,7 @@ int vme_lm_set(struct vme_resource *resource, unsigned long long lm_base,
> >  	lm = list_entry(resource->entry, struct vme_lm_resource, list);
> >  
> >  	if (!bridge->lm_set) {
> > -		dev_err(bridge->parent, "vme_lm_set not supported\n");
> > +		dev_err(bridge->parent, "%s not supported\n", __func__);
> >  		return -EINVAL;
> >  	}
> >  
> > @@ -1612,7 +1612,7 @@ int vme_lm_get(struct vme_resource *resource, unsigned long long *lm_base,
> >  	lm = list_entry(resource->entry, struct vme_lm_resource, list);
> >  
> >  	if (!bridge->lm_get) {
> > -		dev_err(bridge->parent, "vme_lm_get not supported\n");
> > +		dev_err(bridge->parent, "%s not supported\n", __func__);
> >  		return -EINVAL;
> >  	}
> >  
> > @@ -1649,7 +1649,7 @@ int vme_lm_attach(struct vme_resource *resource, int monitor,
> >  	lm = list_entry(resource->entry, struct vme_lm_resource, list);
> >  
> >  	if (!bridge->lm_attach) {
> > -		dev_err(bridge->parent, "vme_lm_attach not supported\n");
> > +		dev_err(bridge->parent, "%s not supported\n", __func__);
> >  		return -EINVAL;
> >  	}
> >  
> > @@ -1682,7 +1682,7 @@ int vme_lm_detach(struct vme_resource *resource, int monitor)
> >  	lm = list_entry(resource->entry, struct vme_lm_resource, list);
> >  
> >  	if (!bridge->lm_detach) {
> > -		dev_err(bridge->parent, "vme_lm_detach not supported\n");
> > +		dev_err(bridge->parent, "%s not supported\n", __func__);
> >  		return -EINVAL;
> >  	}
> >  
> > @@ -1750,7 +1750,7 @@ int vme_slot_num(struct vme_dev *vdev)
> >  	}
> >  
> >  	if (!bridge->slot_get) {
> > -		dev_warn(bridge->parent, "vme_slot_num not supported\n");
> > +		dev_warn(bridge->parent, "%s not supported\n", __func__);
> >  		return -EINVAL;
> >  	}
> >  
> > -- 
> > 2.42.0