Re: [PATCH 1/2] dt-bindings: clock: support i.MX93 Anatop

[Conor Dooley]

On Thu, Oct 19, 2023 at 10:05:54AM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH 1/2] dt-bindings: clock: support i.MX93 Anatop
> > 
> > On Wed, Oct 18, 2023 at 04:44:13PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@xxxxxxx>
> > >
> > > Support i.MX93 Anatop which generates PLL and feeds into CCM.
> > 
> > What is "CCM". How do you "generate" a PLL?
> 
>  
> CCM: Clock Controller Module.

> I may use produces PLL

No, almost certainly it _is_ a PLL and produces a clock.

> > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > > ---
> > >  .../bindings/clock/fsl,imx93-anatop.yaml      | 41 +++++++++++++++++++
> > >  1 file changed, 41 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> > > b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> > > new file mode 100644
> > > index 000000000000..9585c9e4ee40
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> > > @@ -0,0 +1,41 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/clock/fsl,imx93-anatop.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: NXP i.MX93 Anatop Module
> > 
> > I see there are also "anatop regulators" on some imx SoCs, just calling this
> > "anatop module" does not seem sufficiently descriptive.
> 
> Analog Module? How do you think?

It'd probably more be descriptive, but really putting the PLL bit in the
title would be helpful.

I assume "anatop" is what this thing is called in the RTL for the
device.

Cheers,
Conor.

>  
> > 
> > > +
> > > +maintainers:
> > > +  - Peng Fan <peng.fan@xxxxxxx>
> > > +
> > > +description: |
> > 
> > Drop the |, you don't need it.
> 
> Ok.
> 
> > 
> > > +  NXP i.MX93 anatop PLL module which generates PLL to CCM root.
> > > +
> > > +properties:
> > > +  compatible:
> > > +    items:
> > > +      - const: fsl,imx93-anatop
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +  '#clock-cells':
> > > +    const: 1
> > > +
> > > +required:
> > > +  - compatible
> > > +  - reg
> > > +  - '#clock-cells'
> > > +
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > +  - |
> > > +    anatop: clock-controller@44480000 {
> > 
> > and the label is is not used, so should be dropped.
> 
> Ok.
> 
> Thanks,
> Peng.
> 
> > 
> > Thanks,
> > Conor.
> > 
> > > +        compatible = "fsl,imx93-anatop";
> > > +        reg = <0x44480000 0x2000>;
> > > +        #clock-cells = <1>;
> > > +    };
> > > +
> > > +...
> > > --
> > > 2.37.1
> > >

Attachment: signature.asc
Description: PGP signature