RE: [PATCH v8 21/26] dt-bindings: devfreq: event: rockchip,dfi: Add rk3568 support

From: Chanwoo Choi
Date: Thu Oct 19 2023 - 08:27:18 EST




> -----Original Message-----
> From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Sent: Wednesday, October 18, 2023 3:17 PM
> To: linux-rockchip@xxxxxxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-pm@xxxxxxxxxxxxxxx; Heiko Stuebner <heiko@xxxxxxxxx>; Chanwoo Choi
> <chanwoo@xxxxxxxxxx>; Kyungmin Park <kyungmin.park@xxxxxxxxxxx>; MyungJoo
> Ham <myungjoo.ham@xxxxxxxxxxx>; Will Deacon <will@xxxxxxxxxx>; Mark
> Rutland <mark.rutland@xxxxxxx>; kernel@xxxxxxxxxxxxxx; Michael Riesch
> <michael.riesch@xxxxxxxxxxxxxx>; Robin Murphy <robin.murphy@xxxxxxx>;
> Vincent Legoll <vincent.legoll@xxxxxxxxx>; Rob Herring
> <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; Sebastian Reichel
> <sebastian.reichel@xxxxxxxxxxxxx>; Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>;
> Conor Dooley <conor.dooley@xxxxxxxxxxxxx>; Chanwoo Choi
> <cw00.choi@xxxxxxxxxxx>
> Subject: [PATCH v8 21/26] dt-bindings: devfreq: event: rockchip,dfi: Add
> rk3568 support
>
> This adds the rockchip,rk3568-dfi compatible to the binding. Make clocks
> optional for this SoC as the RK3568 doesn't have a kernel controllable
> PCLK.
>
> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> ---
> .../bindings/devfreq/event/rockchip,dfi.yaml | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> index 7a82f6ae0701e..e8b64494ee8bd 100644
> --- a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> @@ -13,6 +13,7 @@ properties:
> compatible:
> enum:
> - rockchip,rk3399-dfi
> + - rockchip,rk3568-dfi
>
> clocks:
> maxItems: 1
> @@ -34,11 +35,21 @@ properties:
>
> required:
> - compatible
> - - clocks
> - - clock-names
> - interrupts
> - reg
>
> +if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - rockchip,rk3399-dfi
> +
> +then:
> + required:
> + - clocks
> + - clock-names
> +
> additionalProperties: false
>
> examples:
> --
> 2.39.2


Applied it. Thanks

Best Regards,
Chanwoo Choi