Re: [PATCH v2 09/11] leds: aw200xx: add support for aw20108 device

From: Andy Shevchenko
Date: Thu Oct 19 2023 - 05:13:05 EST


On Thu, Oct 19, 2023 at 12:10 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Wed, Oct 18, 2023 at 9:30 PM Dmitry Rokosov
> <ddrokosov@xxxxxxxxxxxxxxxxx> wrote:

...

> > - This option enables support for the AW20036/AW20054/AW20072 LED driver.
> > - It is a 3x12/6x9/6x12 matrix LED driver programmed via
> > - an I2C interface, up to 36/54/72 LEDs or 12/18/24 RGBs,
> > + This option enables support for the AW20036/AW20054/AW20072/AW20108
> > + LED driver. It is a 3x12/6x9/6x12/9x12 matrix LED driver programmed via
> > + an I2C interface, up to 36/54/72/108 LEDs or 12/18/24/36 RGBs,
> > 3 pattern controllers for auto breathing or group dimming control.
>
> For better maintenance I always suggest in the cases like this to
> convert help to provide a list of the supported devices, like:
>
> This option enables support for the following Awinic LED drivers:
> - AW20036 (3x12)

(and other specifics can be listed in parentheses, or in free way, but
short enough to occupy only a single line)

> - ...
> ...
>
> And if any new comes to this, it will be just a one liner change.

And you may do that conversion as a precursor to this one and you will
see what I mean.

--
With Best Regards,
Andy Shevchenko