Re: [PATCH v2 0/6] remove AR7 platform and associated drivers

From: Thomas Bogendoerfer
Date: Thu Oct 19 2023 - 04:52:31 EST


On Fri, Sep 22, 2023 at 08:15:21AM +0200, Wolfram Sang wrote:
> Changes since v1:
> * kept uapi define for for serial port type
> * added acks
>
> Still valid cover letter from v1:
>
> When trying to get rid of the obsolete VLYNQ bus, Jonas and Florian
> pointed out that its only user, the AR7 platform can probaly go entirely
> [1]. This series does exactly that. Even OpenWRT has removed support
> because these devices are "stuck with 3.18" [2].
>
> It removes the drivers first, because watchdog and network include
> platform specific headers. Once the drivers are gone, we remove the
> platform. The patches are based on 6.6-rc2 and created with
> "--irreversible-delete" to save some space.
>
> My suggestion is that everything is merged via the MIPS tree in one go,
> so we don't have broken drivers because of missing platform headers. But
> maybe there are reasons for a two-cycle removal with the drivers first
> and the platform later?
>
> Looking forward to comments.
>
> Happy hacking,
>
> Wolfram
>
>
> [1] https://lore.kernel.org/r/3395161f-2543-46f0-83d9-b918800305e1@xxxxxxxxx
> [2] https://openwrt.org/docs/techref/targets/ar7
>
>
> Wolfram Sang (6):
> serial: 8250: remove AR7 support
> mtd: parsers: ar7: remove support
> vlynq: remove bus driver
> watchdog: ar7_wdt: remove driver to prepare for platform removal
> net: cpmac: remove driver to prepare for platform removal
> MIPS: AR7: remove platform
>
> MAINTAINERS | 13 -
> arch/arm/configs/pxa_defconfig | 1 -
> arch/mips/Kbuild.platforms | 1 -
> arch/mips/Kconfig | 22 -
> arch/mips/ar7/Makefile | 11 -
> arch/mips/ar7/Platform | 5 -
> arch/mips/ar7/clock.c | 439 --------
> arch/mips/ar7/gpio.c | 332 ------
> arch/mips/ar7/irq.c | 165 ---
> arch/mips/ar7/memory.c | 51 -
> arch/mips/ar7/platform.c | 722 -------------
> arch/mips/ar7/prom.c | 256 -----
> arch/mips/ar7/setup.c | 93 --
> arch/mips/ar7/time.c | 31 -
> arch/mips/boot/compressed/uart-16550.c | 5 -
> arch/mips/configs/ar7_defconfig | 119 ---
> arch/mips/include/asm/mach-ar7/ar7.h | 191 ----
> arch/mips/include/asm/mach-ar7/irq.h | 16 -
> arch/mips/include/asm/mach-ar7/prom.h | 12 -
> arch/mips/include/asm/mach-ar7/spaces.h | 22 -
> drivers/Kconfig | 2 -
> drivers/Makefile | 1 -
> drivers/mtd/parsers/Kconfig | 5 -
> drivers/mtd/parsers/Makefile | 1 -
> drivers/mtd/parsers/ar7part.c | 129 ---
> drivers/net/ethernet/ti/Kconfig | 9 +-
> drivers/net/ethernet/ti/Makefile | 1 -
> drivers/net/ethernet/ti/cpmac.c | 1251 -----------------------
> drivers/tty/serial/8250/8250_port.c | 7 -
> drivers/vlynq/Kconfig | 21 -
> drivers/vlynq/Makefile | 6 -
> drivers/vlynq/vlynq.c | 799 ---------------
> drivers/watchdog/Kconfig | 6 -
> drivers/watchdog/Makefile | 1 -
> drivers/watchdog/ar7_wdt.c | 315 ------
> include/linux/vlynq.h | 149 ---
> 36 files changed, 1 insertion(+), 5209 deletions(-)
> delete mode 100644 arch/mips/ar7/Makefile
> delete mode 100644 arch/mips/ar7/Platform
> delete mode 100644 arch/mips/ar7/clock.c
> delete mode 100644 arch/mips/ar7/gpio.c
> delete mode 100644 arch/mips/ar7/irq.c
> delete mode 100644 arch/mips/ar7/memory.c
> delete mode 100644 arch/mips/ar7/platform.c
> delete mode 100644 arch/mips/ar7/prom.c
> delete mode 100644 arch/mips/ar7/setup.c
> delete mode 100644 arch/mips/ar7/time.c
> delete mode 100644 arch/mips/configs/ar7_defconfig
> delete mode 100644 arch/mips/include/asm/mach-ar7/ar7.h
> delete mode 100644 arch/mips/include/asm/mach-ar7/irq.h
> delete mode 100644 arch/mips/include/asm/mach-ar7/prom.h
> delete mode 100644 arch/mips/include/asm/mach-ar7/spaces.h
> delete mode 100644 drivers/mtd/parsers/ar7part.c
> delete mode 100644 drivers/net/ethernet/ti/cpmac.c
> delete mode 100644 drivers/vlynq/Kconfig
> delete mode 100644 drivers/vlynq/Makefile
> delete mode 100644 drivers/vlynq/vlynq.c
> delete mode 100644 drivers/watchdog/ar7_wdt.c
> delete mode 100644 include/linux/vlynq.h

applied to mips-next, minus patch 5, which is already applied to net-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]