Re: [PATCH v1 1/1] Revert "pinctrl: avoid unsafe code pattern in find_pinctrl()"

From: Linus Walleij
Date: Thu Oct 19 2023 - 04:13:40 EST


On Tue, Oct 17, 2023 at 4:18 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:


> The commit breaks MMC enumeration on the Intel Merrifield
> plaform.
>
> Before:
> [ 36.439057] mmc0: SDHCI controller on PCI [0000:00:01.0] using ADMA
> [ 36.450924] mmc2: SDHCI controller on PCI [0000:00:01.3] using ADMA
> [ 36.459355] mmc1: SDHCI controller on PCI [0000:00:01.2] using ADMA
> [ 36.706399] mmc0: new DDR MMC card at address 0001
> [ 37.058972] mmc2: new ultra high speed DDR50 SDIO card at address 0001
> [ 37.278977] mmcblk0: mmc0:0001 H4G1d 3.64 GiB
> [ 37.297300] mmcblk0: p1 p2 p3 p4 p5 p6 p7 p8 p9 p10
>
> After:
> [ 36.436704] mmc2: SDHCI controller on PCI [0000:00:01.3] using ADMA
> [ 36.436720] mmc1: SDHCI controller on PCI [0000:00:01.0] using ADMA
> [ 36.463685] mmc0: SDHCI controller on PCI [0000:00:01.2] using ADMA
> [ 36.720627] mmc1: new DDR MMC card at address 0001
> [ 37.068181] mmc2: new ultra high speed DDR50 SDIO card at address 0001
> [ 37.279998] mmcblk1: mmc1:0001 H4G1d 3.64 GiB
> [ 37.302670] mmcblk1: p1 p2 p3 p4 p5 p6 p7 p8 p9 p10
>
> This reverts commit c153a4edff6ab01370fcac8e46f9c89cca1060c2.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Patch applied for pronto fixes!

Yours,
Linus Walleij