[PATCH v2 0/2] staging: vme_user: Replace printk's & clean up log messages

From: Soumya Negi
Date: Thu Oct 19 2023 - 03:20:25 EST


Staging driver vme_user has a bunch of printk() calls in vme.c which
triggers checkpatch warnings. Remove all printk's and change them to
the appropriate logging mechanism i.e pr_err()/pr_warn(), or
dev_err()/dev_warn().

Also, clean up the messages further by using __func__ in the string
instead of function names.

This patchset fixes all checkpatch warnings like:

WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then
dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
&
WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get',
this function's name, in a string

Patches must be applied in order.

Changes in v2:
1. Correct "cleanup" to "clean up" in cover letter. (as per feedback
from julia.lawall@xxxxxxxx)
2. Patch 1: Change the pr_*() calls used to replace printk's in v1 to
dev_*() wherever possible, as it adds more context to the messages.
(as per feedback from julia.lawall@xxxxxxxx &
gregkh@xxxxxxxxxxxxxxxxxxx)

Soumya Negi (2):
staging: vme_user: Replace printk() with pr_*(),dev_*()
staging: vme_user: Use __func__ instead of function name

drivers/staging/vme_user/vme.c | 193 +++++++++++++++++++--------------
1 file changed, 109 insertions(+), 84 deletions(-)

--
2.42.0