Re: [PATCH] dt-bindings: pinctrl: qcom,sa8775p-tlmm: add missing wakeup-parent

From: Krzysztof Kozlowski
Date: Wed Oct 18 2023 - 15:23:14 EST


On 18/10/2023 19:44, Konrad Dybcio wrote:
>
>
> On 10/18/23 16:57, Krzysztof Kozlowski wrote:
>> Add missing wakeup-parent property, already used by DTS to indicate that
>> pins are wakeup capable:
>>
>> sa8775p-ride.dtb: pinctrl@f000000: 'wakeup-parent' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> ---
>> Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>> index e119a226a4b1..2173c5255638 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>> @@ -28,6 +28,7 @@ properties:
>> gpio-controller: true
>> "#gpio-cells": true
>> gpio-ranges: true
>> + wakeup-parent: true
>>
>> gpio-reserved-ranges:
>> minItems: 1
> All the properties visiable in this diff sound reasonable to
> put in the common yaml, no?

Is something missing from common?

Best regards,
Krzysztof