Re: [PATCH v4 1/2] riscv: Add remaining module relocations

From: Andreas Schwab
Date: Wed Oct 18 2023 - 14:48:10 EST


On Okt 17 2023, Charlie Jenkins wrote:

> +static int apply_r_riscv_sub6_rela(struct module *me, u32 *location, Elf_Addr v)
> +{
> + *(u8 *)location = (*location - ((u8)v & 0x3F)) & 0x3F;

I think that should use *(u8*) on both sides.

--
Andreas Schwab, schwab@xxxxxxxxxxxxxx
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."