Re: [PATCH 02/10] x86/mm/cpa: Reject incorrect encryption change requests

From: Edgecombe, Rick P
Date: Wed Oct 18 2023 - 11:53:23 EST


On Wed, 2023-10-18 at 10:44 +0200, Ingo Molnar wrote:
> > +       /*
> > +        * If any page is already in the right state, bail with an
> > error
> > +        * because the code doesn't handled it. This is likely
> > because
>
> Grammar mistake here.
>
> > +        * something has gone wrong and isn't worth optimizing for.
> > +        *
> > +        * If all the memory pages are already in the desired state
> > return
> > +        * success.
>
> Missing comma.
>
> > +        *
> > +        * kernel_vaddr_encryped() does not synchronize against
> > huge page
> > +        * splits so take pgd_lock. A caller doing strange things
> > could
>
> Missing comma.

Oh, yep. Thanks.