Re: [PATCH] iomap: fix short copy in iomap_write_iter()

From: Christoph Hellwig
Date: Wed Oct 18 2023 - 11:52:34 EST


On Wed, Oct 18, 2023 at 04:32:19PM +0200, Jan Stancek wrote:
> On Wed, Oct 18, 2023 at 2:22 PM Christoph Hellwig <hch@xxxxxx> wrote:
> >
> > On Wed, Oct 18, 2023 at 10:24:20AM +0200, Jan Stancek wrote:
> > > Make next iteration retry with amount of bytes we managed to copy.
> >
> > The observation and logic fix look good. But I wonder if simply
> > using a goto instead of the extra variable would be a tad cleaner?
> > Something like this?
>
> Looks good to me. Would you be OK if I re-posted it as v2 with your
> Signed-off-by added?

Please skip my signoff. This is really your work and I just a very
cosmetic suggestion.