Re: [PATCH net v3] net: ti: icssg-prueth: Fix r30 CMDs bitmasks

From: Andrew Lunn
Date: Wed Oct 18 2023 - 11:12:37 EST


On Wed, Oct 18, 2023 at 08:37:15PM +0530, MD Danish Anwar wrote:
> The bitmasks for EMAC_PORT_DISABLE and EMAC_PORT_FORWARD r30 commands are
> wrong in the driver.
>
> Update the bitmasks of these commands to the correct ones as used by the
> ICSSG firmware. These bitmasks are backwards compatible and work with
> any ICSSG firmware version.
>
> Fixes: e9b4ece7d74b ("net: ti: icssg-prueth: Add Firmware config and classification APIs.")
> Signed-off-by: MD Danish Anwar <danishanwar@xxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew