Re: [PATCH v3] ACPI: NFIT: Use cleanup.h helpers instead of devm_*()

[Rafael J. Wysocki]

On Wed, Oct 18, 2023 at 6:28 AM Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
>
> Michal Wilczynski wrote:
> > The new cleanup.h facilities that arrived in v6.5-rc1 can replace the
> > the usage of devm semantics in acpi_nfit_init_interleave_set(). That
> > routine appears to only be using devm to avoid goto statements. The
> > new __free() annotation at variable declaration time can achieve the same
> > effect more efficiently.
> >
> > There is no end user visible side effects of this patch, I was
> > motivated to send this cleanup to practice using the new helpers.
> >
> > Suggested-by: Dave Jiang <dave.jiang@xxxxxxxxx>
> > Suggested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> > Reviewed-by: Dave Jiang <dave.jiang@xxxxxxxxx>
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> > Signed-off-by: Michal Wilczynski <michal.wilczynski@xxxxxxxxx>
> > ---
> >
> > Dan, would you like me to give you credit for the changelog changes
> > with Co-developed-by tag ?
>
> Nope, this looks good to me, thanks for fixing it up.
>
> Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>

Are you going to apply it too, or should I take it?