Re: [PATCH] staging: rts5208: Replace delay function.

From: Andi Shyti
Date: Wed Oct 18 2023 - 06:38:36 EST


Hi Julia,

> > Replace udelay() with usleep_range() for more precise delay handling.
> >
> > Reported by checkpatch:
> >
> > CHECK: usleep_range is preferred over udelay
>
> This message is typically not a good candidate for outreachy patches,
> because you need access to the device to be sure that any change is
> correct.

I actually don't really mind this patch... I would exchange these
udelay() with almost anything, they look to me placed a bit
random anyway (without going too much in detail).

But in general, for this project, I think you are right and it's
a good idea not to blindly change delay and sleeping functions
without really knowing what you are doing.

Andi