Re: [patch V5 03/39] x86/boot/32: De-uglify the 2/3 level paging difference in mk_early_pgtbl_32()

From: Borislav Petkov
Date: Wed Oct 18 2023 - 06:00:44 EST


On Tue, Oct 17, 2023 at 11:23:26PM +0200, Thomas Gleixner wrote:
> Move the ifdeffery out of the function and use proper typedefs to make it
> work for both 2 and 3 level paging.
>
> No functional change.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> ---
> V5: New patch
> ---
> arch/x86/kernel/head32.c | 38 +++++++++++++++++++++-----------------
> 1 file changed, 21 insertions(+), 17 deletions(-)
>
> --- a/arch/x86/kernel/head32.c
> +++ b/arch/x86/kernel/head32.c
> @@ -71,39 +71,43 @@ asmlinkage __visible void __init __noret
> */
> void __init mk_early_pgtbl_32(void);

Lemme zap that forward declaration too - it looks redundant.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette