Re: [PATCH 5/5] modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules

From: Christoph Hellwig
Date: Wed Oct 18 2023 - 01:31:56 EST


On Wed, Oct 18, 2023 at 01:30:18AM +0100, David Woodhouse wrote:
>
> But if we're going to tolerate the core kernel still exporting some
> stuff with EXPORT_SYMBOL, why isn't OK for a GPL-licensed module do to
> the same? Even an *in-tree* GPL-licensed module now can't export
> functionality with EXPORT_SYMBOL and have it used with symbol_get().

Anything using symbol_get is by intent very deeply internal for tightly
coupled modules working together, and thus not a non-GPL export.

In fact the current series is just a stepping stone. Once some mess
in the kvm/vfio integration is fixed up we'll require a new explicit
EXPORT_SYMBOL variant as symbol_get wasn't ever intended to be used
on totally random symbols not exported for use by symbol_get.