Re: [PATCH v3 3/5] mm: memcg: add per-memcg zswap writeback stat

From: Nhat Pham
Date: Tue Oct 17 2023 - 19:40:59 EST


On Tue, Oct 17, 2023 at 4:38 PM Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> wrote:
>
> On 10/17/2023 4:35 PM, Nhat Pham wrote:
> > On Tue, Oct 17, 2023 at 4:21 PM Nhat Pham <nphamcs@xxxxxxxxx> wrote:
> >>
> >> From: Domenico Cerasuolo <cerasuolodomenico@xxxxxxxxx>
> >>
> >> Since zswap now writes back pages from memcg-specific LRUs, we now need a
> >> new stat to show writebacks count for each memcg.
> >>
> >> Suggested-by: Nhat Pham <nphamcs@xxxxxxxxx>
> >> Signed-off-by: Domenico Cerasuolo <cerasuolodomenico@xxxxxxxxx>
> >> Signed-off-by: Nhat Pham <nphamcs@xxxxxxxxx>
> >
> > /s/Signed-off/Acked
> > This is Domenico's work :) I used the wrong tag here. Should be:
> > Acked-by: Nhat Pham <nphamcs@xxxxxxxxx>
>
> no, since you are posting the patch, you have to sign off on it.
> Signed-off-by is correct
>

Ah so past Nhat was right all along. Ignore my comments then.
Thanks for letting me know, Jeff!