Re: [PATCH v2 4/5] ioctl_userfaultfd.2: fix / update UFFDIO_REGISTER error code list

From: Alejandro Colomar
Date: Tue Oct 17 2023 - 17:42:39 EST


Hi Guillem!

On Tue, Oct 17, 2023 at 11:23:10PM +0200, Guillem Jover wrote:
> Hi!
>
> On Mon, 2023-10-09 at 00:06:48 +0200, Alejandro Colomar wrote:
> > This produces some unwanted space. Please apply the following fix to
> > your patch.
> >
> > diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2
> > index 6e954e98c..795014794 100644
> > --- a/man2/ioctl_userfaultfd.2
> > +++ b/man2/ioctl_userfaultfd.2
> > @@ -432,11 +432,11 @@ .SS UFFDIO_REGISTER
> > no mapping exists in the given range,
> > or the mapping that exists there is invalid
> > (e.g. unsupported type of memory),
> > -or the range values (
> > -.I range.start
> > +or the range values
> > +.IR ( range.start
>
> I think you meant «.RI» here?

Yup! Good catch.

Cheers,
Alex

>
> > or
> > -.I range.len
> > -) are not multiples of the relevant page size,
> > +.IR range.len )
> > +are not multiples of the relevant page size,
> > or
> > .I range.len
> > is zero.
> >
>
> Regards,
> Guillem

--
<https://www.alejandro-colomar.es/>

Attachment: signature.asc
Description: PGP signature