Re: [PATCH v3] selftests/user_events: Fix abi_test for BE archs

From: Shuah Khan
Date: Tue Oct 17 2023 - 17:10:54 EST


On 10/17/23 14:38, Steven Rostedt wrote:
On Thu, 5 Oct 2023 21:57:12 +0000
Beau Belgrave <beaub@xxxxxxxxxxxxxxxxxxx> wrote:

The abi_test currently uses a long sized test value for enablement
checks. On LE this works fine, however, on BE this results in inaccurate
assert checks due to a bit being used and assuming it's value is the
same on both LE and BE.

Use int type for 32-bit values and long type for 64-bit values to ensure
appropriate behavior on both LE and BE.

Fixes: 60b1af8de8c1 ("tracing/user_events: Add ABI self-test")
Signed-off-by: Beau Belgrave <beaub@xxxxxxxxxxxxxxxxxxx>
---
V3 Changes:
Fix missing cast in clone_check().

V2 Changes:
Rebase to linux-kselftest/fixes.

Shuah,

Can you take this patch?

Acked-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>


Thank you both. Applied to linux-kselftest fixes for Linux 6.6-rc7

thanks,
-- Shuah