Re: [PATCH 2/2] x86/sme: Mark the code as __head in mem_encrypt_identity.c

From: Thomas Gleixner
Date: Tue Oct 17 2023 - 15:51:05 EST


On Tue, Oct 17 2023 at 14:52, Ingo Molnar wrote:
> * Hou Wenlong <houwenlong.hwl@xxxxxxxxxxxx> wrote:
>> -static inline void __init sme_encrypt_kernel(struct boot_params *bp) { }
>> -static inline void __init sme_enable(struct boot_params *bp) { }
>> +static inline void sme_encrypt_kernel(struct boot_params *bp) { }
>> +static inline void sme_enable(struct boot_params *bp) { }
>
> So I think we should preserve the previous convention of marking functions
> __init in the header-declaration and at the definition site as well, and do
> the same with __head as well?

I'm not convinced about the value of prototype annotations, but have no
strong preference either.

Thanks,

tglx