Re: [PATCH] cxl/pmu: Ensure put_device on pmu devices

[Dave Jiang]

On 10/17/23 08:35, Ira Weiny wrote:
> Dave Jiang wrote:
>>
>>
> 
> [snip]
> 
>>>
>>> Properly call device_unregister() to free up the memory associated with
>>> the device.
>>>
>>> Fixes: 1ad3f701c399 ("cxl/pci: Find and register CXL PMU devices")
>>> Cc: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
>>> Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>
>>
>> Reviewed-by: Dave Jiang <dave.jiang@xxxxxxxxx>
>>
>> Although I wonder if we can just give device_unregister() to devm_add_action_or_reset() directly. 
>>
> 
> No because the action callback takes void * and device_unregister() takes
> a struct device *.

Ah right! I knew there was a reason for the wrapper....
> 
> Ira
> 
> [snip]