Re: [PATCH 1/5] i3c: master: svc: enable hotjoin default

From: Frank Li
Date: Tue Oct 17 2023 - 11:07:20 EST


On Tue, Oct 17, 2023 at 04:04:57PM +0200, Miquel Raynal wrote:
> Hi Frank,
>
> Frank.Li@xxxxxxx wrote on Mon, 16 Oct 2023 11:46:28 -0400:
>
> > Hotjoin require clock running and enable SLVSTART irq.
> > Add module parameter 'hotjoin' to disable hotjoin and enable runtime_pm to
> > save power.
>
> I am really not a big fan of the use of modules parameters. Maybe it
> makes sense here. Alex, a better idea?

Maybe we can create sys entry to enable/disable hotjoin. I think i3c
should default support hotjoin, but it exist user case that needn't hj and
want more aggressive power saving.

If create /sys/ entry, it need change driver/i3c/master.c.

Frank

>
> Thanks,
> Miquèl