Re: [PATCH] ASoC: dt-bindings: tas5805m: Disallow undefined properties

From: Conor Dooley
Date: Tue Oct 17 2023 - 06:50:51 EST


On Mon, Oct 16, 2023 at 10:55:47AM -0500, Rob Herring wrote:
> Device specific bindings should not allow undefined properties. This is
> accomplished in json-schema with 'additionalProperties: false'.
>
> Examples should be last in the schema, so move additionalProperties up
> while we're here.
>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>

Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Thanks,
Conor.

> ---
> Documentation/devicetree/bindings/sound/tas5805m.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/tas5805m.yaml b/Documentation/devicetree/bindings/sound/tas5805m.yaml
> index 63edf52f061c..12c41974274e 100644
> --- a/Documentation/devicetree/bindings/sound/tas5805m.yaml
> +++ b/Documentation/devicetree/bindings/sound/tas5805m.yaml
> @@ -37,6 +37,8 @@ properties:
> generated from TI's PPC3 tool.
> $ref: /schemas/types.yaml#/definitions/string
>
> +additionalProperties: false
> +
> examples:
> - |
> i2c {
> @@ -52,5 +54,4 @@ examples:
> ti,dsp-config-name = "mono_pbtl_48khz";
> };
> };
> -
> -additionalProperties: true
> +...
> --
> 2.42.0
>
>

Attachment: signature.asc
Description: PGP signature