Re: [PATCH] ocfs2/dlm: Clean up errors in dlmdomain.c
From: kernel test robot
Date: Tue Oct 17 2023 - 03:13:26 EST
Hi KaiLong,
kernel test robot noticed the following build warnings:
[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on linus/master v6.6-rc6 next-20231017]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/KaiLong-Wang/ocfs2-dlm-Clean-up-errors-in-dlmdomain-c/20231017-115916
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/62e91e34.969.18b27f9ec40.Coremail.wangkailong%40jari.cn
patch subject: [PATCH] ocfs2/dlm: Clean up errors in dlmdomain.c
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231017/202310171436.cr0GHO3X-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310171436.cr0GHO3X-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310171436.cr0GHO3X-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
fs/ocfs2/dlm/dlmdomain.c: In function 'dlm_alloc_pagevec':
>> fs/ocfs2/dlm/dlmdomain.c:78:9: warning: this 'for' clause does not guard... [-Wmisleading-indentation]
78 | for (i = 0; i < pages; i++)
| ^~~
fs/ocfs2/dlm/dlmdomain.c:80:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'for'
80 | if (!(vec[i]))
| ^~
vim +/for +78 fs/ocfs2/dlm/dlmdomain.c
03d864c02c3ea8 Daniel Phillips 2006-03-10 69
03d864c02c3ea8 Daniel Phillips 2006-03-10 70 static void **dlm_alloc_pagevec(int pages)
03d864c02c3ea8 Daniel Phillips 2006-03-10 71 {
6da2ec56059c3c Kees Cook 2018-06-12 72 void **vec = kmalloc_array(pages, sizeof(void *), GFP_KERNEL);
03d864c02c3ea8 Daniel Phillips 2006-03-10 73 int i;
03d864c02c3ea8 Daniel Phillips 2006-03-10 74
03d864c02c3ea8 Daniel Phillips 2006-03-10 75 if (!vec)
03d864c02c3ea8 Daniel Phillips 2006-03-10 76 return NULL;
03d864c02c3ea8 Daniel Phillips 2006-03-10 77
03d864c02c3ea8 Daniel Phillips 2006-03-10 @78 for (i = 0; i < pages; i++)
8586048e6e9be0 KaiLong Wang 2023-10-13 79 vec[i] = (void *)__get_free_page(GFP_KERNEL);
8586048e6e9be0 KaiLong Wang 2023-10-13 80 if (!(vec[i]))
03d864c02c3ea8 Daniel Phillips 2006-03-10 81 goto out_free;
c8f33b6e86af74 Joel Becker 2006-03-16 82
685f1adb3872d9 Mark Fasheh 2006-03-23 83 mlog(0, "Allocated DLM hash pagevec; %d pages (%lu expected), %lu buckets per page\n",
f5a923d1ba648b Mark Fasheh 2006-11-28 84 pages, (unsigned long)DLM_HASH_PAGES,
f5a923d1ba648b Mark Fasheh 2006-11-28 85 (unsigned long)DLM_BUCKETS_PER_PAGE);
03d864c02c3ea8 Daniel Phillips 2006-03-10 86 return vec;
03d864c02c3ea8 Daniel Phillips 2006-03-10 87 out_free:
03d864c02c3ea8 Daniel Phillips 2006-03-10 88 dlm_free_pagevec(vec, i);
03d864c02c3ea8 Daniel Phillips 2006-03-10 89 return NULL;
03d864c02c3ea8 Daniel Phillips 2006-03-10 90 }
03d864c02c3ea8 Daniel Phillips 2006-03-10 91
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki