Re: [net-next PATCH v3 3/4] net: stmmac: move TX timer arm after DMA enable

From: Jakub Kicinski
Date: Mon Oct 16 2023 - 21:08:56 EST


On Sat, 14 Oct 2023 11:29:53 +0200 Christian Marangi wrote:
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 5124ee87286c..240a18b97825 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -2545,7 +2545,8 @@ static void stmmac_bump_dma_threshold(struct stmmac_priv *priv, u32 chan)
> * @queue: TX queue index
> * Description: it reclaims the transmit resources after transmission completes.
> */
> -static int stmmac_tx_clean(struct stmmac_priv *priv, int budget, u32 queue)
> +static int stmmac_tx_clean(struct stmmac_priv *priv, int budget, u32 queue,
> + bool *pending_packets)

Missing kdoc for new param, build with W=1 catches this.
--
pw-bot: cr