Re: [PATCH] staging: emxx_udc: Remove unnecessary parentheses around condition tests

From: Andi Shyti
Date: Mon Oct 16 2023 - 17:28:15 EST


> > Fix 47 warnings detected by checkpatch.pl about unnecessary parenthesis
> > around condition tests.
>
> And as I have stated numerous times in the past, they are not
> "unnecessary" at all, and provide a valuable hint to the developer as to
> what is the ordering involved.
>
> So you can ignore this checkpatch warning please, it's not valid as far
> as I'm concerned for the subsystems that I maintain in the kernel.

I find this very confusing, though:

if (((ep->epnum == 0) || (data & (1 << ep->epnum)) == 0))

Andi