Re: [PATCH 3/5] OPP: Reorder code in _opp_set_required_opps_genpd()

[Ulf Hansson]

On Mon, 16 Oct 2023 at 12:38, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>
> On 16-10-23, 12:11, Ulf Hansson wrote:
> > Why always return 0 and not the error code anymore?
>
> Oops, fixed with:
>
> diff --git a/drivers/opp/core.c b/drivers/opp/core.c
> index 3516e79cf743..42ca52fbe210 100644
> --- a/drivers/opp/core.c
> +++ b/drivers/opp/core.c
> @@ -1076,7 +1076,7 @@ static int _opp_set_required_opps_genpd(struct device *dev,
>  {
>         struct device **genpd_virt_devs =
>                 opp_table->genpd_virt_devs ? opp_table->genpd_virt_devs : &dev;
> -       int index, target, delta, ret;
> +       int index, target, delta, ret = 0;
>
>         /* Scaling up? Set required OPPs in normal order, else reverse */
>         if (!scaling_down) {
> @@ -1105,7 +1105,7 @@ static int _opp_set_required_opps_genpd(struct device *dev,
>
>         mutex_unlock(&opp_table->genpd_virt_dev_lock);
>
> -       return 0;
> +       return ret;
>  }
>
>  /* This is only called for PM domain for now */
>

Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

Kind regards
Uffe