Re: [PATCH v2] media: staging: max96712: fix copy-paste error

From: Niklas Söderlund
Date: Mon Oct 16 2023 - 08:47:12 EST


HI Ihor,

Thanks for your work.

Maybe use a more descriptive commit title? The idea is to describe the
issue a patch addresses in the title. Not the reason why the issue was
introduced, this goes into the commit message. Imagine another
copy-paste error is found in the driver, then we would have two commits
with the same title.

How about?

'media: staging: max96712: Fix device name in description'

On 2023-10-15 22:24:47 +0100, ihor.matushchak@xxxxxxxxxx wrote:
> From: Ihor Matushchak <ihor.matushchak@xxxxxxxxxx>
>
> Fix the device model name in driver description,
> which appears to be a copy-paste error

Super-nit: Missing trailing dot.

>
> Signed-off-by: Ihor Matushchak <ihor.matushchak@xxxxxxxxxx>
> ---
> Changes in v2:
> Add commit message describing the change;
>
> drivers/staging/media/max96712/max96712.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/media/max96712/max96712.c
> index c44145284aa1..ea67bcf69c9d 100644
> --- a/drivers/staging/media/max96712/max96712.c
> +++ b/drivers/staging/media/max96712/max96712.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * Maxim MAX9286 Quad GMSL2 Deserializer Driver
> + * Maxim MAX96712 Quad GMSL2 Deserializer Driver
> *
> * Copyright (C) 2021 Renesas Electronics Corporation
> * Copyright (C) 2021 Niklas Söderlund
> --
> 2.30.2
>

--
Kind Regards,
Niklas Söderlund