Re: [PATCH v3 1/4] tty: whitespaces in descriptions corrected by replacing tabs with spaces.

From: Jiri Slaby
Date: Mon Oct 16 2023 - 08:32:32 EST


On 16. 10. 23, 9:13, Florian Eckert wrote:
Tabs were used in the function description, to make this look more
uniform, the tabs were replaced by spaces where necessary.

Signed-off-by: Florian Eckert <fe@xxxxxxxxxx>

Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>


LGTM (spihnx prefers spaces), except:

@@ -3470,7 +3470,7 @@ int tty_register_driver(struct tty_driver *driver)
EXPORT_SYMBOL(tty_register_driver);
/**
- * tty_unregister_driver -- unregister a tty driver
+ * tty_unregister_driver - unregister a tty driver

you should have noted you changed ndashes to dashes too. (As only the latter is supported by sphinx.)

thanks,
--
js
suse labs