Re: [PATCH v3] perf bench sched pipe: Add -G/--cgroups option

From: Ingo Molnar
Date: Mon Oct 16 2023 - 05:35:46 EST




* Namhyung Kim <namhyung@xxxxxxxxxx> wrote:

> + /* try cgroup v2 interface first */
> + if (threaded)
> + fd = openat(cgrp->fd, "cgroup.threads", O_WRONLY);
> + else
> + fd = openat(cgrp->fd, "cgroup.procs", O_WRONLY);
> +
> + /* try cgroup v1 if failed */
> + if (fd < 0)
> + fd = openat(cgrp->fd, "tasks", O_WRONLY);
> +
> + if (fd < 0) {
> + char mnt[PATH_MAX];
> +
> + printf("Failed to open cgroup file in %s\n", cgrp->name);
> +
> + if (cgroupfs_find_mountpoint(mnt, sizeof(mnt), "perf_event") == 0)
> + printf(" Hint: create the cgroup first, like 'mkdir %s/%s'\n",
> + mnt, cgrp->name);

Ok, this works too I suppose.

Acked-by: Ingo Molnar <mingo@xxxxxxxxxx>

Thanks,

Ingo