Re: [PATCH V1 3/3] ASoC: codecs: Add aw88399 amplifier driver

[wangweidong . a]

Thank you very much for your review

On 13/10/2023 13:50, +200 krzysztof.kozlowski@xxxxxxxxxx wrote:
> On 13/10/2023 12:42, wangweidong.a@xxxxxxxxxx wrote:
>> From: Weidong Wang <wangweidong.a@xxxxxxxxxx>
>> 
>> Add i2c and amplifier registration for
>> aw88399 and their associated operation functions.
>> 


>> +
>> +static void aw88399_hw_reset(struct aw88399 *aw88399)
>> +{
>> +	if (aw88399->reset_gpio) {
>> +		gpiod_set_value_cansleep(aw88399->reset_gpio, 0);
>> +		usleep_range(AW88399_1000_US, AW88399_1000_US + 10);
>> +		gpiod_set_value_cansleep(aw88399->reset_gpio, 1);

> Why do you leave the device in reset state? I think you wanted these
> reverted.

our chip is reset at low level, So I'll change it to
    gpiod_set_value_cansleep(aw88399->reset_gpio, 1);
	usleep_range(AW88399_1000_US, AW88399_1000_US + 10);
	gpiod_set_value_cansleep(aw88399->reset_gpio, 0);
	usleep_range(AW88399_1000_US, AW88399_1000_US + 10);
	gpiod_set_value_cansleep(aw88399->reset_gpio, 1);
Thanks again for your advice.

Best regards,
Weidong Wang