[PATCH] Bluetooth: hci_conn_failed: Fixes memory leak

From: Yuran Pereira
Date: Sat Oct 07 2023 - 07:39:33 EST


The hci_conn_failed() function currently calls hci_connect_cfm(), which
indirectly leads to the allocation of an l2cap_conn struct in l2cap_conn_add().
This operation results in a memory leak, as the l2cap_conn structure
becomes unreferenced.

To address this issue and prevent the memory leak, this patch modifies
hci_conn_failed() to replace the call to hci_connect_cfm() with a
call to hci_disconn_cfm().

Reported-by: syzbot+39ec16ff6cc18b1d066d@xxxxxxxxxxxxxxxxxxxxxxxxx
Signed-off-by: Yuran Pereira <yuran.pereira@xxxxxxxxxxx>
---
net/bluetooth/hci_conn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index 7a6f20338db8..1d2d03b4a98a 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -1248,7 +1248,7 @@ void hci_conn_failed(struct hci_conn *conn, u8 status)
}

conn->state = BT_CLOSED;
- hci_connect_cfm(conn, status);
+ hci_disconn_cfm(conn, status);
hci_conn_del(conn);
}

--
2.25.1