Re: [RFC/RFT PATCH] gpiolib: reverse-assign the fwnode to struct gpio_chip

From: Linus Walleij
Date: Fri Oct 06 2023 - 18:22:17 EST


On Fri, Oct 6, 2023 at 9:08 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:

> I don't see any good reason for it not having the fwnode assigned.
> User calling gpio_device_find() will have to jump through hoops in
> order to match the device by fwnode

Yeah I would add

struct fwnode_handle *gpiochip_get_fwnode(struct gpio_chip *gc)
{
return dev_fwnode(&gc->gpiodev->dev);
}

so it's easy for external users to get the fwnode if they really need it.
This and a few more changes and we can drop gc->fwnode altogether
can't we?

Yours,
Linus Walleij