Re: [PATCH] dt-bindings: pinctrl: st,stm32: fix phandle-array warning

From: Rob Herring
Date: Fri Oct 06 2023 - 13:57:03 EST



On Fri, 06 Oct 2023 10:22:48 +0200, Martin Kaiser wrote:
> make CHECK_DTBS=y st/stm32f469-disco.dtb
>
> brings up a warning about a missing argument:
>
> stm32f469-disco.dtb: pinctrl@40020000: st,syscfg:0: [21, 8] is too short
>
> The description of the third entry indicates that this entry is optional.
> The code in stm32_pctrl_dt_setup_irq parses st,syscfg and treats the third
> entry as optional. It defaults to 0xf if not present in the devicetree.
>
> Update the schema to require at least two entries, use the same syntax as
> the description of renesas,ipmmu-main in
> Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml.
>
> Signed-off-by: Martin Kaiser <martin@xxxxxxxxx>
> ---
>
> I tested the following cases, all of them returned the expected result:
>
> st,syscfg = <&syscfg>; (too short)
> st,syscfg = <&syscfg 0x8>; (ok)
> st,syscfg = <&syscfg 0x8 0x0>; (ok)
> st,syscfg = <&syscfg 0x8 0x0 0x0>; (too long)
>
> .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>

Acked-by: Rob Herring <robh@xxxxxxxxxx>