[PATCH v3] usb: gadget: u_ether: Replace netif_stop_queue with netif_device_detach

From: Hardik Gajjar
Date: Fri Oct 06 2023 - 11:38:22 EST


This patch replaces the usage of netif_stop_queue with netif_device_detach
in the u_ether driver. The netif_device_detach function not only stops all
tx queues by calling netif_tx_stop_all_queues but also marks the device as
removed by clearing the __LINK_STATE_PRESENT bit.

This change helps notify user space about the disconnection of the device
more effectively, compared to netif_stop_queue, which only stops a single
transmit queue.

Signed-off-by: Hardik Gajjar <hgajjar@xxxxxxxxxxxxxx>
---
Changes since version 1:
- Correct Singed-off user name and e-mail

Changes since version 2:
- Move change history below signed-off-by
---
drivers/usb/gadget/function/u_ether.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
index 4bb0553da658..b0daee35b996 100644
--- a/drivers/usb/gadget/function/u_ether.c
+++ b/drivers/usb/gadget/function/u_ether.c
@@ -635,7 +635,7 @@ static int eth_stop(struct net_device *net)
unsigned long flags;

VDBG(dev, "%s\n", __func__);
- netif_stop_queue(net);
+ netif_device_detach(dev->net);

DBG(dev, "stop stats: rx/tx %ld/%ld, errs %ld/%ld\n",
dev->net->stats.rx_packets, dev->net->stats.tx_packets,
--
2.17.1