Re: [PATCH v2 2/2] printk: Reduce pr_flush() pooling time

From: John Ogness
Date: Fri Oct 06 2023 - 06:12:17 EST


On 2023-10-06, Petr Mladek <pmladek@xxxxxxxx> wrote:
> pr_flush() does not guarantee that all messages would really get flushed
> to the console. The best it could do is to wait with a given timeout.[*]
>
> The current interval 100ms for checking the progress might seem too
> long in some situations. For example, such delays are not appreciated
> during suspend and resume especially when the consoles have been flushed
> "long" time before the check.
>
> One the other hand, the sleeping wait might be useful in other situations.

"One" should be "On"

Otherwise the patch looks OK to me. Thanks!

Reviewed-by: John Ogness <john.ogness@xxxxxxxxxxxxx>