Re: [RFC PATCH] ARM: dts: at91: sama5d3_eds: remove TDES use

From: claudiu beznea
Date: Fri Oct 06 2023 - 04:16:01 EST


Hi, Nicolas, Jerry,

On 28.09.2023 17:56, nicolas.ferre@xxxxxxxxxxxxx wrote:
> From: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
>
> TDES doesn't probe because of lack of DMA channels left on this
> controller. As we don't need TDES HW engine, we prefer to keep DMA
> channels for other usage.
> Disable TDES for this board.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
> ---
> Hi,
>
> Tell me what you think about this move. I think it makes sense but tell me if
> application could suffer from this lack of TDES engine.

It anyway fails to probe. I have nothing against unless its probing could
be fixed. Jerry, are you good with applying this?

Thank you,
Claudiu Beznea

>
> Regards,
> Nicolas
>
> arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts b/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
> index c287b03d768b..fddd786f8483 100644
> --- a/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
> +++ b/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
> @@ -284,6 +284,10 @@ timer1: timer@1 {
> };
> };
>
> +&tdes {
> + status = "disabled";
> +};
> +
> &usb0 { /* USB Device port with VBUS detection. */
> atmel,vbus-gpio = <&pioE 9 GPIO_ACTIVE_HIGH>;
> pinctrl-names = "default";